Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch and save aspect ratio for responsive embeds #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fetch and save aspect ratio for responsive embeds #8

wants to merge 1 commit into from

Conversation

daun
Copy link

@daun daun commented Nov 11, 2016

  • Added new column to db: aspect_ratio
  • Added method to handle the db schema update
  • Fetches width and height from oEmbed to determine video’s aspect ratio for proper responsive embedding
  • Added new module config field: defaultAspectRatio (used when aspect ratio can’t be determined from oEmbed request)
  • Bumbed version to 112

@daun
Fetch and save aspect ratio for responsive embeds
76e9a5e 
– Added new column to db: aspect_ratio
– Added method to handle the db schema update
– Fetches width and height from oEmbed to determine video’s aspect ratio for proper responsive embedding
– Added new module config field: defaultAspectRatio (used when aspect ratio can’t be determined from oEmbed request)
– Bumbed version to 112
@cb2004
Copy link

cb2004 commented Jun 20, 2017

I really like this @philippdaun. Can this be merged @ryancramerdesign?

@ryancramerdesign ryancramerdesign mentioned this pull request May 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daun @cb2004